Skip to content

fix: files list sort accessibility#7056

Merged
vitormattos merged 6 commits intomainfrom
fix/files-list-sort-accessibility
Mar 2, 2026
Merged

fix: files list sort accessibility#7056
vitormattos merged 6 commits intomainfrom
fix/files-list-sort-accessibility

Conversation

@vitormattos
Copy link
Copy Markdown
Member

No description provided.

…ssibility improvements

- Replace scoped &-icon with :deep() to reach slot content in Vue 3
- Set :size="24" on NcIconSvgWrapper to match Files app icon size
- Simplify template to single NcIconSvgWrapper with computed isAscending
- Add :title="name" to NcButton for tooltip and screen reader hint

Signed-off-by: Vitor Mattos <[email protected]>
…n accessibility

- Import and expose filesSortingStore via setup() replacing dead local data() properties
- Fix ariaSortForMode('basename') -> ariaSortForMode('name') mismatch with button mode prop
- Return 'none' instead of null for sortable-but-inactive columns (required by ARIA spec)
- Add scope="col" to all <th> elements so screen readers associate headers with columns

Signed-off-by: Vitor Mattos <[email protected]>
Cover isAscending computed property, --active CSS class presence,
and toggleSortBy delegation for active/inactive column states

Signed-off-by: Vitor Mattos <[email protected]>
…eHeader

Verify ascending/descending/none/null return values and corresponding
aria-sort DOM attribute for sortable and non-sortable columns

Signed-off-by: Vitor Mattos <[email protected]>
Upload PDF, add signer, send request, navigate to Files list sorted by
Created at descending, rename to unique name, assert Ready to sign status,
delete via actions menu and confirm row disappears

Signed-off-by: Vitor Mattos <[email protected]>
Upload PDF, place a visible signature element, save, navigate away and
return to verify the element persists, then delete it and confirm it is
removed after a second round-trip

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos added this to the Next Major (34) milestone Mar 2, 2026
@vitormattos vitormattos self-assigned this Mar 2, 2026
@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Mar 2, 2026
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable33

@vitormattos vitormattos merged commit c62bb8f into main Mar 2, 2026
69 checks passed
@vitormattos vitormattos deleted the fix/files-list-sort-accessibility branch March 2, 2026 20:11
@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 4. to release in Roadmap Mar 2, 2026
@vitormattos
Copy link
Copy Markdown
Member Author

/backport to stable32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant